added tests for quantized tflite sin operator #9478
Conversation
onkar-sima-ai
requested review from
Huyuwei,
areusch,
comaniac,
icemelon,
jroesch,
junrushao,
jwfromm,
kazum,
mbrookhart,
merrymercy,
siju-samuel,
srkreddy1238,
tqchen and
yzhliu
as code owners
There was a problem hiding this comment.
The PR in general LGTM.
I see there are a few linting errors when running this in CI. You can see on this page how to reproduce linting errors locally on your machine: https://tvm.apache.org/docs/contribute/pull_request.html
You can see the errors here as well: https://ci.tlcpack.ai/blue/organizations/jenkins/tvm/detail/PR-9478/2/pipeline
Once we get this PR past CI, I'm happy for this to be merged.
|
Hi @leandron I am not sure if the failure of CI has to do anything with the changes I introduced. |
onkar-sima-ai
force-pushed
the
tvmc-tflite-sin
branch
from
e1b6684 to
15ac6e5
Compare
|
Hi @leandron |
|
Hi @leandron The CI has passed, Can you please merge this PR https://ci.tlcpack.ai/blue/organizations/jenkins/tvm/detail/PR-9478/4/pipeline/269/ |
leandron
left a comment
leandron
left a comment
There was a problem hiding this comment.
LGTM, thanks @onkar-sima-ai !
* added tests for quantized tflite sin operator * removing unnecessary rsqrt code_block * resolving linting error
* added tests for quantized tflite sin operator * removing unnecessary rsqrt code_block * resolving linting error
* added tests for quantized tflite sin operator * removing unnecessary rsqrt code_block * resolving linting error
* added tests for quantized tflite sin operator * removing unnecessary rsqrt code_block * resolving linting error
* added tests for quantized tflite sin operator * removing unnecessary rsqrt code_block * resolving linting error
2 participants
#9187
I have added support for quantized SIN tflite operator and wrote tests for the same.
Thanks for contributing to TVM! Please refer to guideline https://tvm.apache.org/docs/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from Reviewers by @ them in the pull request thread.