Skip to content

Fixed some warnings about lambda's closures that are bigger than necessary #9481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
comaniac merged 3 commits into from
Nov 11, 2021
Merged

Fixed some warnings about lambda's closures that are bigger than necessary #9481

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0d93f3c
Fixed some warnings, including lambdas closure that are bigger than n…
FranckQC Nov 9, 2021
ec1cc99
Fixed formatting as two lines can now be merged while still being und…
FranckQC Nov 10, 2021
0b11772
Merge branch 'apache:main' into fix-warningsLambdas
FranckQC Nov 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/driver/driver_api.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@ transform::Pass BindTarget(Target target) {
}

static transform::Pass AnnotateEntryFunc(bool b) {
auto fpass = [b](tir::PrimFunc f, IRModule m, transform::PassContext ctx) {
auto fpass = [](tir::PrimFunc f, IRModule m, transform::PassContext ctx) {
return WithAttr(std::move(f), tir::attr::kIsEntryFunc, Bool(true));
};
return tir::transform::CreatePrimFuncPass(fpass, 0, "AnnotateEntryFunc", {});
Expand Down
3 changes: 1 addition & 2 deletions src/relay/backend/vm/compiler.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -618,8 +618,7 @@ class VMFunctionCompiler : DeviceAwareExprFunctor<void(const Expr& n)> {
}
})
.Match("memory.alloc_storage",
[this, call_node](const Array<Expr>& args, const Attrs& attrs,
const Array<Type>& type_arg) {
[this](const Array<Expr>& args, const Attrs& attrs, const Array<Type>& type_arg) {
ICHECK_EQ(args.size(), 2);
// Compute the size of the allocation.
this->VisitExpr(args[0]);
Expand Down