-
Notifications
You must be signed in to change notification settings - Fork 3.8k
Add LLVM-13 installation to Docker setup #9498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* Installs LLVM 13 in for Ubuntu 18.04 Docker images * This is needed as a requirement for apache#9425
|
@tqchen @areusch @jroesch @u99127 and all other previously mentioned, I wonder how many LLVM version you consider we should maintain on our pipeline. At this moment we have 5 versions (9 to 13, with this PR). I was thinking we could remove 9 and 10? My main concern is bloating the Docker image with stuff we don't need/use. Thoughts? |
Mousius
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ace @leandron! I like the clean up of the apt-get line, though I think maybe a line per version rather than a line of llvm then clang versions. But don't hold up this going in as I think we should land this and get CI back up to speed then address removing some older versions as a separate piece of work 😸
junrushao
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* main: (119 commits) [Topi][Op][PyTorch][Vitas] Fix inconsistent kernel layout conventions for conv2d_transpose (apache#9336) Fix repository URL in ubuntu_install_rocm.sh (apache#9425) Add LLVM-13 installation to Docker setup (apache#9498) [Relay] Use target_host determined at Relay level instead of recalculating it (apache#9499) Arm(R) Ethos(TM)-U NPU BinaryElementwise operators support (apache#9442) [COMMUNITY] Junru's and Wuwei's PGP key for ASF release (apache#9488) Add default for split op (apache#9489) [HOTFIX][TARGET] Change LOG in compilation config to DLOG (apache#9486) Fixed some warnings about lambda's closures that are bigger than necessary (apache#9481) [Support] Add libinfo into the runtime build (apache#9310) Change Call with TIRCallAttrs to call_lowered op (apache#9312) [ETHOSN] Streamline Ethos(TM)-N cross-compile rpc usage (apache#9477) [CMSIS-NN] Assert correct amount of CMSIS-NN artifacts in MLF (apache#9480) [MicroTVM][PyTest] Explicitly skip MicroTVM unittests. (apache#9335) [microNPU] Replace ICHECK with diagnostic context in type inference (apache#9470) Better host handling in CompilationConfig & debug printing (apache#9460) [AOT][Tests] Use pre-built libraries in Reference System tests (apache#9271) [TIR] Add type hint for TIR (apache#9432) [TVMC] Add test for quantized pytorch model (apache#9467) [CMSIS-NN] Convert CMSIS-NN to use Target Hooks (apache#9397) ...
|
This log confirms the fix actually works when rebuilding the Docker images: https://ci.tlcpack.ai/blue/organizations/jenkins/docker-images-ci%2Fdaily-docker-image-rebuild/detail/daily-docker-image-rebuild/109/pipeline |
* Installs LLVM 13 in for Ubuntu 18.04 Docker images * This is needed as a requirement for apache#9425
* Installs LLVM 13 in for Ubuntu 18.04 Docker images * This is needed as a requirement for apache#9425
* Installs LLVM 13 in for Ubuntu 18.04 Docker images * This is needed as a requirement for apache#9425
* Installs LLVM 13 in for Ubuntu 18.04 Docker images * This is needed as a requirement for apache#9425
* Installs LLVM 13 in for Ubuntu 18.04 Docker images * This is needed as a requirement for apache#9425
Add LLVM-13 installation to Docker setup:
cc @masahi @jtuyls @Mousius for reviews