-
Notifications
You must be signed in to change notification settings - Fork 3.8k
[DNNL] Add support of QNN primitives for DNNL runtime #9618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Please update this PR. |
Signed-off-by: Alexander Peskov <peskovnn@gmail.com>
Signed-off-by: Alexander Peskov <peskovnn@gmail.com>
Signed-off-by: Alexander Peskov <peskovnn@gmail.com>
Signed-off-by: Alexander Peskov <peskovnn@gmail.com>
Signed-off-by: Alexander Peskov <peskovnn@gmail.com>
Signed-off-by: Alexander Peskov <peskovnn@gmail.com>
Signed-off-by: Alexander Peskov <peskovnn@gmail.com>
Signed-off-by: Alexander Peskov <peskovnn@gmail.com>
4a23a9f to
d221e85
Compare
Signed-off-by: Alexander Peskov <peskovnn@gmail.com>
Signed-off-by: Alexander Peskov <peskovnn@gmail.com>
Signed-off-by: Alexander Peskov <peskovnn@gmail.com>
Signed-off-by: Alexander Peskov <peskovnn@gmail.com>
Signed-off-by: Alexander Peskov <peskovnn@gmail.com>
|
@masahi PR is updated. You may continue review. |
|
@tmoreau89 @gfursin Just FYI. |
|
Thanks @apeskov - I'm also looping in @mbs-octoml on the review of this PR |
If that's the case, I want this PR to be split into smaller ones. It's hard to review 3K PR with lots of moving pieces. Indeed 3K is too big for just introducing int8 support. |
masahi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At least changes in dnnl_json_runtime.cc and dnnl_node_helper.h are relatively unrelated to int8. Please send them first.
Also we use CamelCase throughout the codebase, so please follow the convention.
|
Closing, feel free to reopen. |
The main value of that change is enable qnn.conv2d and qnn.dense primitive for DNNL base json runtime.
Some of these changes is useful for all type of workloads, not only int8 specific.
Together with that there was performed some refactoring of internal infrastructure of DNNL plugin. The main int8 unrelated changes are: