[microNPU] Fixing imports in the entry point #9624
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manupak
requested review from
MarisaKirisame,
ZihengJiang,
anijain2305,
icemelon,
jroesch,
junrushao,
jwfromm,
mbrookhart,
slyubomirsky,
vinx13,
wweic,
yzhliu and
zhiics
as code owners
Contributor
Author
|
cc : @leandron @dchauhan-arm |
leandron
approved these changes
Dec 1, 2021
Contributor
leandron
left a comment
leandron
left a comment
There was a problem hiding this comment.
LGTM, just curious on why we don't see these failing on CI right now?
Contributor
Author
|
So this only came up when @dchauhan-arm was removing a python module of the microNPU but mistakenly not removing all the imports -- so technically it should result in an import error for that module. However, it resulted as if Vela was missing. Also it will only show up for devs, not users. |
This commit fixes errornous reporting that Vela is missing if other import errors. Change-Id: I8db97be10018726cf5d9483508321a176c212516
manupak
force-pushed
the
fix_micronpu_imports
branch
from
429f02f to
f4cd40d
Compare
Contributor
|
This is merged now. Thanks @manupa-arm and @dchauhan-arm! |
lhutton1
added a commit
to lhutton1/tvm
that referenced
this pull request
Dec 2, 2021
Fixes failing CI since CI on apache#9576 passed before apache#9624 was merged. Change-Id: I44f6aa0abe09d206f3e948e36e9799eaa12b3d14
manupak
pushed a commit
that referenced
this pull request
Dec 2, 2021
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 7, 2022
This commit fixes errornous reporting that Vela is missing if other import errors. Change-Id: I8db97be10018726cf5d9483508321a176c212516
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 7, 2022
Fixes failing CI since CI on apache#9576 passed before apache#9624 was merged. Change-Id: I44f6aa0abe09d206f3e948e36e9799eaa12b3d14
yangulei
pushed a commit
to yangulei/tvm
that referenced
this pull request
Jan 11, 2022
This commit fixes errornous reporting that Vela is missing if other import errors. Change-Id: I8db97be10018726cf5d9483508321a176c212516
yangulei
pushed a commit
to yangulei/tvm
that referenced
this pull request
Jan 11, 2022
Fixes failing CI since CI on apache#9576 passed before apache#9624 was merged. Change-Id: I44f6aa0abe09d206f3e948e36e9799eaa12b3d14
yangulei
pushed a commit
to yangulei/tvm
that referenced
this pull request
Jan 12, 2022
This commit fixes errornous reporting that Vela is missing if other import errors. Change-Id: I8db97be10018726cf5d9483508321a176c212516
yangulei
pushed a commit
to yangulei/tvm
that referenced
this pull request
Jan 12, 2022
Fixes failing CI since CI on apache#9576 passed before apache#9624 was merged. Change-Id: I44f6aa0abe09d206f3e948e36e9799eaa12b3d14
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 13, 2022
This commit fixes errornous reporting that Vela is missing if other import errors. Change-Id: I8db97be10018726cf5d9483508321a176c212516
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 13, 2022
Fixes failing CI since CI on apache#9576 passed before apache#9624 was merged. Change-Id: I44f6aa0abe09d206f3e948e36e9799eaa12b3d14
qsqqsqqsq-intellif
pushed a commit
to qsqqsqqsq-intellif/tvm
that referenced
this pull request
Apr 29, 2022
This commit fixes errornous reporting that Vela is missing if other import errors. Change-Id: I8db97be10018726cf5d9483508321a176c212516
qsqqsqqsq-intellif
pushed a commit
to qsqqsqqsq-intellif/tvm
that referenced
this pull request
Apr 29, 2022
Fixes failing CI since CI on apache#9576 passed before apache#9624 was merged. Change-Id: I44f6aa0abe09d206f3e948e36e9799eaa12b3d14
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes errornous reporting that Vela
is missing if other import errors.