-
Notifications
You must be signed in to change notification settings - Fork 3.8k
[TVMC] micro, run: Disable micro support when USE_MICRO=OFF #9632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
leandron
merged 1 commit into
apache:main
from
gromero:tvmc-disable-micro-support-if-not-build-with-microtvm
Dec 2, 2021
Merged
[TVMC] micro, run: Disable micro support when USE_MICRO=OFF #9632
leandron
merged 1 commit into
apache:main
from
gromero:tvmc-disable-micro-support-if-not-build-with-microtvm
Dec 2, 2021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
Do not generate 'tvmc micro' subcommand and disable micro device option in 'tvmc run' when TVM is built without support for microTVM, i.e. with set(USE_MICRO OFF). Signed-off-by: Gustavo Romero <gustavo.romero@linaro.org>
818b36f to
2ed59eb
Compare
leandron
approved these changes
Dec 2, 2021
Contributor
leandron
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Contributor
Contributor
qsqqsqqsq-intellif
pushed a commit
to qsqqsqqsq-intellif/tvm
that referenced
this pull request
Apr 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not generate 'tvmc micro' subcommand and disable micro device option
in 'tvmc run' when TVM is built without support for microTVM, i.e. with
set(USE_MICRO OFF).
Otherwise tvmc will crash on importing any
tvm.micromodule / class. For instance:For any user, which is bad specially for the ones not interested in using
tvmcfor micro targets.