Skip to content

[Hexagon] Detect link-params via IRModule instead of target attribute #9695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
masahi merged 1 commit into from
Dec 11, 2021
Merged

[Hexagon] Detect link-params via IRModule instead of target attribute #9695

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion python/tvm/target/target.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -638,13 +638,27 @@ def create_llvm_options(cpu_ver, config): # pylint: disable=unused-argument
args = [s.replace("=", "@") for s in llvm_options.split()]
return "--llvm-options=" + ",".join(args)

# TVM target attributes string
def create_tvm_options(cpu_ver, config): # pylint: disable=unused-argument
"""Create TVM target features string."""

features = {
"link_params": "link-params",
}
opts = ""
for k in config:
if k in features:
opts += " --" + features[k] + "=" + str(config[k])
return opts

# Sim args
os.environ["HEXAGON_SIM_ARGS"] = create_sim_options(cpu_ver, config)

target_str = create_llvm_target(cpu_ver, config)
llvm_str = create_llvm_options(cpu_ver, config)
tvm_str = create_tvm_options(cpu_ver, config)

args_list = target_str.split() + llvm_str.split()
args_list = target_str.split() + llvm_str.split() + tvm_str.split()

return Target(" ".join(["hexagon"] + args_list))

Expand Down
2 changes: 1 addition & 1 deletion src/target/llvm/codegen_hexagon.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -737,7 +737,7 @@ runtime::Module BuildHexagon(IRModule mod, Target target) {
std::vector<PrimFunc> funcs;
std::string entry_func;
Map<String, LinkedParam> linked_params;
bool could_have_linked_params = target->GetAttr<Bool>("link-params").value_or(Bool(false));
bool could_have_linked_params = mod->ShouldLinkParameters();

for (auto kv : mod->functions) {
if (could_have_linked_params &&
Expand Down