Follow up from CMSIS-NN Pooling failure #9708
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I68861b97d294744b3474f08b23ac890c3222c16c
asparkhi
requested review from
areusch,
comaniac,
icemelon,
jroesch,
junrushao,
manupak,
mbaret,
merrymercy,
tqchen,
trevor-m,
yzhliu and
zhiics
as code owners
Contributor
Author
|
Could you folks @ekalda @manupa-arm please take a look at it? |
Contributor
|
Thanks! @ashutosh-arm |
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 7, 2022
This commit fixes few comments in TIR2Runtime pass of CMSIS-NN target.
These comments specify layout used by CMSIS-NN API
for input and filter shapes.
Another fix was done to the filter layout calculations.
Instead of hard coded values for dimensions,
filter_shape.find("H") was used to locate a particular value.
Third fix was done to the padding API used by Conv2D and Pooling tests.
It was made generic for TFLu's "SAME" padding type.
yangulei
pushed a commit
to yangulei/tvm
that referenced
this pull request
Jan 11, 2022
This commit fixes few comments in TIR2Runtime pass of CMSIS-NN target.
These comments specify layout used by CMSIS-NN API
for input and filter shapes.
Another fix was done to the filter layout calculations.
Instead of hard coded values for dimensions,
filter_shape.find("H") was used to locate a particular value.
Third fix was done to the padding API used by Conv2D and Pooling tests.
It was made generic for TFLu's "SAME" padding type.
yangulei
pushed a commit
to yangulei/tvm
that referenced
this pull request
Jan 12, 2022
This commit fixes few comments in TIR2Runtime pass of CMSIS-NN target.
These comments specify layout used by CMSIS-NN API
for input and filter shapes.
Another fix was done to the filter layout calculations.
Instead of hard coded values for dimensions,
filter_shape.find("H") was used to locate a particular value.
Third fix was done to the padding API used by Conv2D and Pooling tests.
It was made generic for TFLu's "SAME" padding type.
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 13, 2022
This commit fixes few comments in TIR2Runtime pass of CMSIS-NN target.
These comments specify layout used by CMSIS-NN API
for input and filter shapes.
Another fix was done to the filter layout calculations.
Instead of hard coded values for dimensions,
filter_shape.find("H") was used to locate a particular value.
Third fix was done to the padding API used by Conv2D and Pooling tests.
It was made generic for TFLu's "SAME" padding type.
qsqqsqqsq-intellif
pushed a commit
to qsqqsqqsq-intellif/tvm
that referenced
this pull request
Apr 29, 2022
This commit fixes few comments in TIR2Runtime pass of CMSIS-NN target.
These comments specify layout used by CMSIS-NN API
for input and filter shapes.
Another fix was done to the filter layout calculations.
Instead of hard coded values for dimensions,
filter_shape.find("H") was used to locate a particular value.
Third fix was done to the padding API used by Conv2D and Pooling tests.
It was made generic for TFLu's "SAME" padding type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR addresses comments by @ekalda and @manupa-arm from #9682 and #9531. Those issues were about Pooling support in CMSIS-NN and fix for a network failure in Conv2D partitioning.