Skip to content

Conversation

@sunggg
Copy link
Contributor

@sunggg sunggg commented Dec 16, 2021

Nice to meet you all.

This PR contains several changes in meta_scheudle runner and builder.
Please review this and feel free to give any feedback.

Thank you!

Copy link
Member

@junrushao junrushao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good! @sunggg let's fix the CI :-)

@junrushao
Copy link
Member

CC: @Hzfengsy @yidawang

Copy link
Contributor

@comaniac comaniac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@junrushao junrushao changed the title [MetaScheduler] Misc improvement of the Measurer [MetaSchedule] Misc improvement of the Measurer Dec 16, 2021
@junrushao
Copy link
Member

Hey you forgot the fix the two "ditto"s :-)

Copy link
Member

@Hzfengsy Hzfengsy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sunggg
Copy link
Contributor Author

sunggg commented Dec 17, 2021

@junrushao1994, Aren't there three files in total?
My new commit contains changes in three files you mentioned.

I'm now seeing this message.

Some checks were not successful
2 successful and 1 errored checks

Since I'm new to this system, any advice would be greatly appreciated!

@junrushao
Copy link
Member

Oh I’m sorry that I misread! The linter error this time is that we forgot to add docs for “params” in c++

@junrushao
Copy link
Member

CC @zxybazh for review

Copy link
Member

@zxybazh zxybazh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @sunggg !

@junrushao junrushao merged commit 115919b into apache:main Dec 18, 2021
ylc pushed a commit to ylc/tvm that referenced this pull request Jan 7, 2022
Co-authored-by: Junru Shao <junrushao1994@gmail.com>
ylc pushed a commit to ylc/tvm that referenced this pull request Jan 13, 2022
Co-authored-by: Junru Shao <junrushao1994@gmail.com>
@junrushao junrushao changed the title [MetaSchedule] Misc improvement of the Measurer [MetaSchedule][M4b] Misc improvement of the Measurer Jan 26, 2022
qsqqsqqsq-intellif pushed a commit to qsqqsqqsq-intellif/tvm that referenced this pull request Apr 29, 2022
Co-authored-by: Junru Shao <junrushao1994@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants