[microNPU] Re-enable LayoutOptimizer pass #9793
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It looks like in apache#9597 the LayoutOptimizer pass was accidentally removed. Probably due to a race condition in PR's. Re-enabling this feature. Change-Id: I4fc16a440f90277c5fcd887715166332af052c6b
lhutton1
requested review from
MarisaKirisame,
ZihengJiang,
anijain2305,
icemelon,
jroesch,
junrushao,
jwfromm,
mbrookhart,
slyubomirsky,
vinx13,
wweic,
yzhliu and
zhiics
as code owners
ekalda
reviewed
Dec 22, 2021
Contributor
ekalda
left a comment
ekalda
left a comment
There was a problem hiding this comment.
I wonder if it would make sense to run the LUT pass before the layout optimization pass since the LUT pass removes some of the identity operators (which the layout pass currently skips IIRC), so in that case we could transform more layouts between transformation-eligible operators?
Contributor
Author
|
Yes I think that would make more sense! |
Change-Id: I6e7a22f46660029bbf4be3deb2be929cecf5d365
ekalda
approved these changes
Dec 22, 2021
Contributor
ekalda
left a comment
ekalda
left a comment
There was a problem hiding this comment.
Well done for spotting that bug/git fail, LGTM! Fingers crossed all the tests pass when both of these passes are enabled 😅
Contributor
|
Oops.... I also think we need to have at least a single integration test that requires the this pass being run -- maybe in a follow up? |
Contributor
|
Thanks all! Lets add a test to make sure it doesn't get removed silently... |
Contributor
Author
|
Yes that's sensible, will do! |
lhutton1
added a commit
to lhutton1/tvm
that referenced
this pull request
Jan 4, 2022
…line Follow up to apache#9793. In checking this it was found that both the layout and LUT optimizer passes were silently not running. This is fixed by converting each pass to a module pass, rather than a function pass. Tests have been added to prevent this happening in the future. Change-Id: I5145c6f02eeb0daea3cdba56198e0804ec32f351
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 7, 2022
* [microNPU] Re-enable LayoutOptimizer pass It looks like in apache#9597 the LayoutOptimizer pass was accidentally removed. Probably due to a race condition in PR's. Re-enabling this feature. Change-Id: I4fc16a440f90277c5fcd887715166332af052c6b * change pass ordering Change-Id: I6e7a22f46660029bbf4be3deb2be929cecf5d365 Co-authored-by: lukhut01 (generated by with_the_same_user script) <lukhut01@e127400.cambridge.arm.com>
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 13, 2022
* [microNPU] Re-enable LayoutOptimizer pass It looks like in apache#9597 the LayoutOptimizer pass was accidentally removed. Probably due to a race condition in PR's. Re-enabling this feature. Change-Id: I4fc16a440f90277c5fcd887715166332af052c6b * change pass ordering Change-Id: I6e7a22f46660029bbf4be3deb2be929cecf5d365 Co-authored-by: lukhut01 (generated by with_the_same_user script) <lukhut01@e127400.cambridge.arm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like the LayoutOptimizer pass was accidentally removed. Probably due to a race condition when merging PR's. Re-enabling this feature.
cc @ekalda @manupa-arm @mbaret