[Fix] Fix flaky test of #9952 #9958
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wrongtest-intellif
requested review from
Hzfengsy,
ZihengJiang,
junrushao,
kparzysz-quic,
masahi,
tqchen and
vinx13
as code owners
wrongtest-intellif
force-pushed
the
fix_random_vars_order_in_region_analysis
branch
from
66852ba to
a67f850
Compare
wrongtest-intellif
requested review from
areusch,
comaniac,
icemelon,
jroesch,
merrymercy and
yzhliu
as code owners
Contributor
|
Thanks @wrongtest for the fix! If you can make sure the indeterminism doesn't happen again, please also kindly revert this hot fix PR (#9956) by removing the "skip" mark and the pytest import. |
MasterJH5574
approved these changes
Jan 18, 2022
Contributor
MasterJH5574
left a comment
MasterJH5574
left a comment
There was a problem hiding this comment.
LGTM. Please take a look at my comment, thanks!
src/tir/transforms/ir_utils.cc
Outdated
Comment on lines
283
to
288
| for (const Var& var : cand_vars) { | ||
| if (!var_set.count(var)) { | ||
| vars.push_back(var); | ||
| var_set.insert(var); | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
Personally I recommend using std::find(vars.begin(), vars.end(), var) != vars.end() instead of using a var_set for looking up, because usually we don't have few variables and the map doesn't bring performance improvement :-)
Contributor
Author
There was a problem hiding this comment.
std::find(vars.begin(), vars.end(), var) != vars.end()
Thanks for the advice~ I would change to O(n) search and commit to retrigger CI again.
yuanfz98
pushed a commit
to yuanfz98/tvm
that referenced
this pull request
Jan 24, 2022
* fix to stablize the var orders when solve bounds in region analysis * change to std::find_if since num of vars is generally small
crazydemo
pushed a commit
to crazydemo/tvm
that referenced
this pull request
Jan 27, 2022
* fix to stablize the var orders when solve bounds in region analysis * change to std::find_if since num of vars is generally small
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Feb 16, 2022
* fix to stablize the var orders when solve bounds in region analysis * change to std::find_if since num of vars is generally small
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #9952