[Hexagon] Return pathlib.Path from get_hexagon_rpc_path() #9969
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Type annotations don't do anything, the type conversion needs to be explicit.
kparzysz-quic
requested review from
comaniac,
icemelon,
jroesch,
junrushao,
tqchen,
yzhliu and
zhiics
as code owners
Contributor
Author
|
cc: @mehrdadh |
Contributor
Author
|
The reason for this is that if someone wants to initialize |
mehrdadh
approved these changes
Jan 18, 2022
Member
mehrdadh
left a comment
mehrdadh
left a comment
There was a problem hiding this comment.
Thanks for this change! LGTM
masahi
approved these changes
Jan 19, 2022
yuanfz98
pushed a commit
to yuanfz98/tvm
that referenced
this pull request
Jan 24, 2022
Type annotations don't do anything, the type conversion needs to be explicit.
crazydemo
pushed a commit
to crazydemo/tvm
that referenced
this pull request
Jan 27, 2022
Type annotations don't do anything, the type conversion needs to be explicit.
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Feb 16, 2022
Type annotations don't do anything, the type conversion needs to be explicit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type annotations don't do anything, the type conversion needs to be explicit.
Thanks for contributing to TVM! Please refer to guideline https://tvm.apache.org/docs/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from Reviewers by @ them in the pull request thread.