Skip to content
This repository was archived by the owner on May 12, 2021. It is now read-only.

Conversation

@westmann
Copy link
Member

No description provided.

Copy link
Contributor

@prestoncarman prestoncarman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain the general reason for these changes? It looks like we have some new dependencies (such as com.google.guava, org.json, log4j) Its a little hard to tell due to the reordering of several dependencies.

@westmann
Copy link
Member Author

I used mvn dependency:analyze to find out which dependencies we actually had in the code vs which we had declared in the poms. We had some which we didn't declare in the poms but which we used - those only worked because another dependency recursively depended on them. And there were some that we declared but never used. So the ones that are apparently new should be the ones that we used but didn't declare.

@prestoncarman
Copy link
Contributor

The change looks good. Did this ever get merged?

@prestoncarman
Copy link
Contributor

These changes have been merged. I pull this change and updated it for master. This can be closed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants