Skip to content
This repository was archived by the owner on May 12, 2021. It is now read-only.

Conversation

@ankitladhania
Copy link

Issue No. : VXQUERY-139
Description : Previously executing queries with compileonly flag
gave NPE, which was due to null value of IHyracksClientConnection.

Solver : @ankitladhania

Issue No. : VXQUERY-139
Description : Previously executing queries with compileonly flag
gave NPE, which was due to null value of IHyracksClientConnection.

Solver : ankitladhania
int index = 0;
for (String node : nodeControllerInfos.keySet()) {
nodeList[index++] = node;
if(hcc != null) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please format the code according to our standard. You can load the eclipse format file into your IDE.

@prestoncarman
Copy link
Contributor

Thanks for submitting a fix. Take a look at [1] to set up your IDE to format the code.

[1] http://vxquery.apache.org/development_eclipse_setup.html

@ankitladhania
Copy link
Author

Hi Preston,
Can you please tell me about the command for test suite of the project ?
The docs are incorrect.

Regards,
Ankit

@ankitladhania
Copy link
Author

Hi Preston,
I have made changes as discussed please review it.

Regards,
Ankit

@prestoncarman
Copy link
Contributor

Thanks for fixing the formatting. I liked the first two commits, so I squashed them and merged them into master. After looking at the third in more detail, I found it was extra code that did not improve the code base. Please confirm it's working and comment on the issue.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants