feat: Add SQL support for multi-condition joins#698
Open
makarandhinge wants to merge 2 commits intoapache:mainfrom
Open
feat: Add SQL support for multi-condition joins#698makarandhinge wants to merge 2 commits intoapache:mainfrom
makarandhinge wants to merge 2 commits intoapache:mainfrom
Conversation
- Enhanced WayangMultiConditionJoinVisitor with SQL implementation - Updated JdbcJoinOperator to generate AND clauses for multi-column joins - Added test coverage for multi-condition join SQL generation - Maintains backward compatibility with single-condition joins
Contributor
|
Hi, it doesn't seem like your test case tests the implementation |
Author
|
Thank you @mspruc for the feedback! You’re right |
- Execute generated SQL against HSQLDB to verify actual join behavior - Validate row count (2 matching rows expected) - Verify data integrity of joined results - Test edge case: order with mismatched customer_id is correctly excluded - Confirm multi-condition AND clause works end-to-end
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Todo #545