Skip to content

feat: Add SQL support for multi-condition joins#698

Open
makarandhinge wants to merge 2 commits intoapache:mainfrom
makarandhinge:feat/multi-condition-join-sql-support
Open

feat: Add SQL support for multi-condition joins#698
makarandhinge wants to merge 2 commits intoapache:mainfrom
makarandhinge:feat/multi-condition-join-sql-support

Conversation

@makarandhinge
Copy link

@makarandhinge makarandhinge commented Feb 24, 2026

Todo #545

  • Enhanced WayangMultiConditionJoinVisitor with SQL implementation
  • Updated JdbcJoinOperator to generate AND clauses for multi-column joins
  • Added test coverage for multi-condition join SQL generation
  • Maintains backward compatibility with single-condition joins

- Enhanced WayangMultiConditionJoinVisitor with SQL implementation
- Updated JdbcJoinOperator to generate AND clauses for multi-column joins
- Added test coverage for multi-condition join SQL generation
- Maintains backward compatibility with single-condition joins
@makarandhinge makarandhinge changed the title feat: Add SQL support for multi-condition joins feat: Add SQL support for multi-condition joins #545 Feb 24, 2026
@makarandhinge makarandhinge changed the title feat: Add SQL support for multi-condition joins #545 feat: Add SQL support for multi-condition joins Feb 24, 2026
@mspruc
Copy link
Contributor

mspruc commented Feb 25, 2026

Hi, it doesn't seem like your test case tests the implementation

@makarandhinge
Copy link
Author

Thank you @mspruc for the feedback! You’re right
the current test only checks the SQL string generation and doesn’t actually verify execution. Right now it covers things like SQL generation with AND clauses and correct table and column names. We could improve it by running the generated SQL and checking the results, such as making sure the correct number of rows is returned, joins match properly (for example, order_id=1 and customer_id=100), and data from both tables is combined correctly. Would you like me to add a full integration test to validate execution and results?

- Execute generated SQL against HSQLDB to verify actual join behavior
- Validate row count (2 matching rows expected)
- Verify data integrity of joined results
- Test edge case: order with mismatched customer_id is correctly excluded
- Confirm multi-condition AND clause works end-to-end
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants