[WICKET-7162] avoid a NPE when a JavaxUpgradeHttpRequest is created i… #1223
+29
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reiern70
commented
Aug 11, 2025
|
|
||
| if (httpSession == null) | ||
| { | ||
| this.contextPath = "/"; |
Contributor
Author
There was a problem hiding this comment.
@martin-g I'm not sure this is correct or if this path is used anywhere else.. I was looking into code base and didn't see any other object from where we could take the path. We are getting this NPE from time to time on our test severs...
Member
There was a problem hiding this comment.
I am not sure either. It should be OK.
martin-g
reviewed
Aug 11, 2025
| userProperties.put("session", httpSession); | ||
| userProperties.put(JavaxUpgradeHttpRequest.SESSION, httpSession); | ||
| } else { | ||
| sec.getPath(); |
|
|
||
| if (httpSession == null) | ||
| { | ||
| this.contextPath = "/"; |
Member
There was a problem hiding this comment.
I am not sure either. It should be OK.
reiern70
commented
Aug 12, 2025
| if (requestURI != null) | ||
| { | ||
| userProperties.put("requestURI", requestURI); | ||
| String path = requestURI.getPath(); |
Contributor
Author
There was a problem hiding this comment.
@martin-g I think this should always work.
reiern70
commented
Aug 12, 2025
...cket-javax/src/main/java/org/apache/wicket/protocol/ws/javax/WicketServerEndpointConfig.java
Show resolved
Hide resolved
reiern70
commented
Aug 12, 2025
...bsocket-javax/src/main/java/org/apache/wicket/protocol/ws/javax/JavaxUpgradeHttpRequest.java
Show resolved
Hide resolved
martin-g
approved these changes
Aug 12, 2025
…n a situation when there is no session (e.g. some stateless page) and extract context from requestedUI
reiern70
force-pushed
the
reiern70/WICKET-7162
branch
from
d531a56 to
c574107
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…n a situation when there is no session (e.g. some stateless page).