Skip to content

Conversation

@pohanhuang
Copy link
Contributor

@pohanhuang pohanhuang commented Dec 9, 2025

What is this PR for?

  • bump go compiler to 1.24, toolchain to 1.24.11

What type of PR is it?

  • - Bug Fix
  • - Improvement
  • - Feature
  • - Documentation
  • - Hot Fix
  • - Refactoring

Todos

  • - Task

What is the Jira issue?

How should this be tested?

Screenshots (if appropriate)

Questions:

  • - The licenses files need update.
  • - There is breaking changes for older versions.
  • - It needs documentation.

Signed-off-by: hhcs9527 <hhcs9527@gmail.com>
@pbacsko
Copy link
Contributor

pbacsko commented Dec 11, 2025

@pohanhuang I don't think we need to bump the Go version in go.mod to 1.25. Having it on 1.24 should be perfectly fine. In both the shim and core, we use 1.24 with the toolchain being 1.24.11.

Also pls check locally what's wrong with the changes as the linter is complaining.

Signed-off-by: hhcs9527 <hhcs9527@gmail.com>
@pohanhuang pohanhuang changed the title [YUNIKORN-3176] bump go compiler to 1.25 [YUNIKORN-3176] bump go compiler to 1.24 Dec 12, 2025
@pohanhuang
Copy link
Contributor Author

pohanhuang commented Dec 12, 2025

Hi @pbacsko ,
Thanks for reminding, I have change the go.mod to 1.24, toolchain to 1.24.11
Run the test locally, and it works.
Please help review when you are available, thanks

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 38.77%. Comparing base (f5fab75) to head (cbbff1b).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #245   +/-   ##
=======================================
  Coverage   38.77%   38.77%           
=======================================
  Files           2        2           
  Lines          49       49           
=======================================
  Hits           19       19           
  Misses         27       27           
  Partials        3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pbacsko pbacsko closed this in f40c0db Dec 12, 2025
@pbacsko pbacsko reopened this Dec 12, 2025
@pbacsko pbacsko closed this Dec 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants