ZOOKEEPER-3530 Include compiled C-client in the binary tarball

[symat]

After PR #993 for ZOOKEEPER-3436 is merged, maven will build the C-client and put them under the folder zookeeper-client/zookeeper-client-c/target/c.

When we are generating a tarball during full-build using e.g. the mvn clean install -DskipTests -Pfull-build command, then we would expect the compiled C-client to end up in the binary tarball, just like it happened during the older (3.4.x) ant builds.

[eolivelli]

What happens if you are not building with -Pfull-build ?

[symat]

I think the consistent behaviour would be that when -Pfull-build is not present, then there should be no C-client binary in the tarball.

After adding this patch to the top of your current patch in ZOOKEEPER-3436, I got the following:

output of the mvn clean -Pfull-build && mvn install -Pfull-build -Dskip-tests:

bin
  |--- ...
conf
  |--- ...
lib
  |--- ...
usr
  |--- bin
         |--- cli_mt
         |--- cli_st
         |--- load_gen
  |--- include
         |--- zookeeper
                |--- proto.h
                |--- recordio.h
                |--- zookeeper.h
                |--- zookeeper.jute.h
                |--- zookeeper_log.h
                |--- zookeeper_version.h
  |--- lib
         |--- libzookeeper_mt.a
         |--- libzookeeper_mt.la
         |--- libzookeeper_mt.so
         |--- libzookeeper_mt.so.2
         |--- libzookeeper_mt.so.2.0.0
         |--- libzookeeper_st.a
         |--- libzookeeper_st.la
         |--- libzookeeper_st.so
         |--- libzookeeper_st.so.2
         |--- libzookeeper_st.so.2.0.0
LICENSE.txt
NOTICE.txt
README.md
README_packaging.txt

and the output of the mvn clean -Pfull-build && mvn install -Dskip-tests:

bin
  |--- ...
conf
  |--- ...
lib
  |--- ...
LICENSE.txt
NOTICE.txt
README.md
README_packaging.txt

[symat]

I am closing this PR, as we discussed a different approach. I updated the JIRA ticket