ZOOKEEPER-3641: New ZOO_VERSION define breaks Perl & Python contribs

[ztzg]

ZOOKEEPER-3635 changed the versioning scheme for the C client from integer-valued ZOO_{MAJOR,MINOR,PATCH}_VERSION definitions to a single string-valued #define ZOO_VERSION "3.6.0".

This caused the Perl and Python contribs to fail to build. The attached patches should repair the issue.

@eolivelli, @nkalmar: What do you think?

[asf-ci]

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build-maven/1698/

[eolivelli]

My bad!
I did not check the contrib modules!

Let's commit this fix and fix master branch.

Is there any way to create a script (or use Maven) to build these modules in Travis?

It would be good to move this 'official' clients to the zookeeper-clients module and move them out of 'contrib'

I thought they were quite unused but id there is interested we should bring them to the front row together with the C client

[ztzg]

Hi @eolivelli,

(Github tells me you "requested changes," but I cannot find review notes. Is it only about the questions below, or am I missing something?)

My bad! I did not check the contrib modules!

Right; this is bound to happen if they are not part of the release checklist.

Let's commit this fix and fix master branch.

Okay :)

Is there any way to create a script (or use Maven) to build these modules in Travis?

I suppose this is the "change" you are requesting? I can have a look, but should such a thing not be done as another PR/ticket? (I'm not familiar with the plumbing of the Apache/Maven CI, and have no idea of how many iterations it will require.)

It would be good to move this 'official' clients to the zookeeper-clients module and move them out of 'contrib'
I thought they were quite unused but id there is interested we should bring them to the front row together with the C client

I am aware of some users of the "official" Perl client. I don't know any users of the "official" Python client; most seem to be using Kazoo instead.

[symat]

Is there any way to create a script (or use Maven) to build these modules in Travis?

in #1121 I did some changes to be able to build zkpython at least with ant (it broke after the ant removal). I think it would be relatively easy to implement the maven-based build jobs as well (at least for zkpython). Although I am not sure how long do we want to keep these contrib projects in the main ZooKeeper repo.

[eolivelli]

Sorry, I meant to click on "Approve"

[eolivelli]

@nkalmar PTAL and merge if you approve this patch

[ztzg]

Is there any way to create a script (or use Maven) to build these modules in Travis?

in #1121 I did some changes to be able to build zkpython at least with ant (it broke after the ant removal). I think it would be relatively easy to implement the maven-based build jobs as well (at least for zkpython).

Right. I can cargo-cult Maven stanzas, but I don't have the slightest idea of how to get "native" dependencies installed on build hosts at this point.

I see this in the build log:

checking for perl... /usr/bin/perl

and I suppose Python is there too—but I don't know if development headers are available. I guess I could "just try." But given a build host such as Agent H14, would you know if it is possible to retrieve a manifest of installed packages?

Although I am not sure how long do we want to keep these contrib projects in the main ZooKeeper repo.

Note that @eolivelli was suggesting to promote them from zookeeper-contrib/* to zookeeper-client/*, not to get rid of them :)

[eolivelli]

It is better to use Travis.
With travis you can install your dependencies, like we do for cppunit

[ztzg]

Okay—noted!

[nkalmar]

Nice catch, +1

[nkalmar]

Thanks @ztzg , merged to master (3.6.0)

The travis integration can be done in a separate Jira.