ZOOKEEPER-4262: Backport ZOOKEEPER-3911 to branch-3.5 #1657
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cket Author: Brian Nixon <nixon@fb.com> Reviewers: hanm@apache.org, eolivelli@apache.org, andor@apache.org Closes apache#996 from enixon/learner-close-socket and squashes the following commits: 57f5e89 [Brian Nixon] delete ReconfigFailureCasesTest::testLeaderTimesoutOnNewQuorum as it relies on the fixed buggy behavior 1598b3a [Brian Nixon] remove extraneous check on socket status 381889d [Brian Nixon] ZOOKEEPER-3240: Close socket on Learner shutdown to avoid dangling socket
ZOOKEEPER-3911 requires ZOOKEEPER-3240 to pass the unit test.
eolivelli
approved these changes
Mar 28, 2021
Contributor
eolivelli
left a comment
eolivelli
left a comment
There was a problem hiding this comment.
LGTM
I followed the original patch.
It is good to have the fix on branch-3.5
Thanks
ztzg
pushed a commit
that referenced
this pull request
Apr 21, 2021
[ZOOKEEPER-3911 - Data inconsistency caused by DIFF sync uncommitted log](https://issues.apache.org/jira/browse/ZOOKEEPER-3911) [ZOOKEEPER-3240 - Close socket on Learner shutdown to avoid dangling socket](https://issues.apache.org/jira/browse/ZOOKEEPER-3240) ZOOKEEPER-3911 requires ZOOKEEPER-3240 to pass the unit test. Author: fanyang <fanyang@smartx.com> Author: Brian Nixon <nixon@fb.com> Reviewers: Enrico Olivelli <eolivelli@apache.org>, Damien Diederen <ddiederen@apache.org> Closes #1657 from fanyang89/ZOOKEEPER-4262 and squashes the following commits: aaba063 [fanyang] ZOOKEEPER-4262: Backport ZOOKEEPER-3911 to branch-3.5 c2f2216 [Brian Nixon] ZOOKEEPER-3240: Close socket on Learner shutdown to avoid dangling so…
Contributor
|
Now in branch |
Member
|
Close as already merged . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ZOOKEEPER-3911 - Data inconsistency caused by DIFF sync uncommitted log
ZOOKEEPER-3240 - Close socket on Learner shutdown to avoid dangling socket
ZOOKEEPER-3911 requires ZOOKEEPER-3240 to pass the unit test.