ZOOKEEPER-4453: NettyServerCnxnFactory: allow to configure the early TLS connection drop feature#1800
Closed
eolivelli wants to merge 4 commits intoapache:masterfrom
Closed
ZOOKEEPER-4453: NettyServerCnxnFactory: allow to configure the early TLS connection drop feature#1800eolivelli wants to merge 4 commits intoapache:masterfrom
eolivelli wants to merge 4 commits intoapache:masterfrom
Conversation
…TLS connection drop feature - add new flag netty.server.earlyDropSecureConnectionHandshakes to turn on/off ZOOKEEPER-3682 - disable ZOOKEEPER-3682 by default - add docs - add tests for this patch and for ZOOKEEPER-3682
Contributor
Author
|
I had problems with #1799 |
symat
approved these changes
Jan 26, 2022
Contributor
symat
left a comment
symat
left a comment
There was a problem hiding this comment.
LGTM. My only question left is if we should also convert the other "throw new IOException("ZK down");" in NettyServerCnx.receiveMessage() (was around line 477). But I don't think this is crucial, I let you to decide.
Contributor
Author
|
asfgit
pushed a commit
that referenced
this pull request
Jan 27, 2022
…TLS connection drop feature - add new flag netty.server.earlyDropSecureConnectionHandshakes to turn on/off ZOOKEEPER-3682 - disable ZOOKEEPER-3682 by default - add docs - add tests for this patch and for ZOOKEEPER-3682 see https://issues.apache.org/jira/browse/ZOOKEEPER-4453 for more context Author: Enrico Olivelli <eolivelli@apache.org> Reviewers: Mate Szalay-Beko <symat@apache.org> Closes #1800 from eolivelli/fix/ZOOKEEPER-4453-b
Contributor
|
Thanks @eolivelli for the fix! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see https://issues.apache.org/jira/browse/ZOOKEEPER-4453 for more context