ZOOKEEPER-3996: Fix flaky ReadOnlyModeTest.testConnectionEvents #1896
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
#1667(ZOOKEEPER-4271) proposed another approach. But it have not updated for almost one year. |
kezhuw
force-pushed
the
ZOOKEEPER-3996-flaky-ReadOnlyModeTest-testConnectionEvents
branch
from
c7f8638 to
ffb31f7
Compare
kezhuw
force-pushed
the
ZOOKEEPER-3996-flaky-ReadOnlyModeTest-testConnectionEvents
branch
from
ffb31f7 to
ff05cc3
Compare
The same watcher was resued across different clients. It is hard to know which event will last during verification, disconnected from old client or connected from new client. A brand new watcher solves this.
kezhuw
force-pushed
the
ZOOKEEPER-3996-flaky-ReadOnlyModeTest-testConnectionEvents
branch
from
ff05cc3 to
b1073c3
Compare
Member
Author
|
The old test could not last 10 runs after adding After patch with |
Contributor
|
Submitted and Jira resolved. Thanks @kezhuw ! |
anurag-harness
pushed a commit
to anurag-harness/zookeeper
that referenced
this pull request
Aug 31, 2023
…he#1896) The same watcher was resued across different clients. It is hard to know which event will last during verification, disconnected from old client or connected from new client. A brand new watcher solves this.
anurag-harness
added a commit
to anurag-harness/zookeeper
that referenced
this pull request
Aug 31, 2023
rahulrane50
pushed a commit
to rahulrane50/zookeeper
that referenced
this pull request
Sep 15, 2023
…he#1896) The same watcher was resued across different clients. It is hard to know which event will last during verification, disconnected from old client or connected from new client. A brand new watcher solves this.
kezhuw
deleted the
ZOOKEEPER-3996-flaky-ReadOnlyModeTest-testConnectionEvents
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The same watcher was resued across different clients. It is hard to
know which event will last during verification, disconnected from old
client or connected from new client.
A brand new watcher solves this.