ZOOKEEPER-3240: Close socket on Learner shutdown to avoid dangling so… #767
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eolivelli
approved these changes
Jan 11, 2019
Contributor
eolivelli
left a comment
eolivelli
left a comment
There was a problem hiding this comment.
Looks good.
This is the kind of patch which can stay without new tests.
Would be good to cherry pick to 3.5
hanm
approved these changes
Jan 11, 2019
Contributor
|
retest this please |
Contributor
|
Committed to 3.5 and master branches. |
RokLenarcic
pushed a commit
to RokLenarcic/zookeeper
that referenced
this pull request
Sep 3, 2022
…cket Author: Brian Nixon <nixon@fb.com> Reviewers: hanm@apache.org, andor@apache.org Closes apache#767 from enixon/learner-close-socket
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…cket