ZOOKEEPER-3253: client should not send requests with cxid=-4, -2, or -1 #844
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add test for cxid rollover to 1 - Modify ClientCnxn.SendThread.getXid() to increment from MAX to 1. Author: Samuel Just <sjust@salesforce.com> Reviewers: phunt@apache.org Closes apache#787 from athanatos/forupstream/ZOOKEEPER-3253 Change-Id: Ib3d111170bb086d6982f2cf0ee5cf8afd5157588 (cherry picked from commit e10c93a) Includes backport of createConnection testability refactor from 9f82798. Signed-off-by: Samuel Just <sjust@salesforce.com>
asfgit
pushed a commit
that referenced
this pull request
Mar 8, 2019
- Add test for cxid rollover to 1 - Modify ClientCnxn.SendThread.getXid() to increment from MAX to 1. Author: Samuel Just <sjustsalesforce.com> Reviewers: phuntapache.org Closes #787 from athanatos/forupstream/ZOOKEEPER-3253 Change-Id: Ib3d111170bb086d6982f2cf0ee5cf8afd5157588 (cherry picked from commit e10c93a) Includes backport of createConnection testability refactor from 9f82798. Signed-off-by: Samuel Just <sjustsalesforce.com> Author: Samuel Just <sjust@salesforce.com> Reviewers: phunt@apache.org Closes #844 from athanatos/forupstream/ZOOKEEPER-3235-3.4
Contributor
|
+1 thanks @athanatos ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Author: Samuel Just sjust@salesforce.com
Reviewers: phunt@apache.org
Closes #787 from athanatos/forupstream/ZOOKEEPER-3253
Change-Id: Ib3d111170bb086d6982f2cf0ee5cf8afd5157588
(cherry picked from commit e10c93a)
Includes backport of createConnection testability refactor
from 9f82798.
Signed-off-by: Samuel Just sjust@salesforce.com