Skip to content

chore: storage interface support ReadObject function #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wangyelei merged 1 commit into from
Nov 7, 2023
Merged

chore: storage interface support ReadObject function #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions pkg/storage/rclone/rclone.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,15 @@ func (s *rcloneStorage) Pull(ctx context.Context, rpath string, w io.Writer) err
return err
}

func (s *rcloneStorage) ReadObject(ctx context.Context, rpath string) (io.ReadCloser, error) {
rpath = normalizeRemotePath(rpath)
obj, err := s.f.NewObject(ctx, rpath)
if err != nil {
return nil, err
}
return obj.Open(ctx)
}

func (s *rcloneStorage) Remove(ctx context.Context, rpath string, recursive bool) error {
rpath = normalizeRemotePath(rpath)
if !recursive {
Expand Down
3 changes: 3 additions & 0 deletions pkg/storage/types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,9 @@ type Storage interface {
// Stat returns the information about the given path.
// The `rpath` parameter can be a file.
Stat(ctx context.Context, rpath string) (StatResult, error)

// ReadObject reads a file.
ReadObject(ctx context.Context, rpath string) (io.ReadCloser, error)
}

type staticDirEntry struct {
Expand Down