Skip to content

chore: skip wait for addons ready if addon list is empty#623

Merged
shanshanying merged 1 commit into
mainfrom
support/skip-addon-wait-if-empty
Aug 26, 2025
Merged

chore: skip wait for addons ready if addon list is empty#623
shanshanying merged 1 commit into
mainfrom
support/skip-addon-wait-if-empty

Conversation

@shanshanying
Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot added the size/S Denotes a PR that changes 10-29 lines. label Aug 26, 2025
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Aug 26, 2025

Codecov Report

❌ Patch coverage is 11.11111% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 41.90%. Comparing base (8e2af87) to head (65f3f67).
⚠️ Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
pkg/cmd/kubeblocks/install.go 0.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #623      +/-   ##
==========================================
- Coverage   41.91%   41.90%   -0.02%     
==========================================
  Files         184      184              
  Lines       24644    24651       +7     
==========================================
  Hits        10329    10329              
- Misses      13161    13168       +7     
  Partials     1154     1154              
Flag Coverage Δ
unittests 41.90% <11.11%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@shanshanying shanshanying merged commit 6efc4fb into main Aug 26, 2025
19 checks passed
@shanshanying shanshanying deleted the support/skip-addon-wait-if-empty branch August 26, 2025 11:47
@shanshanying
Copy link
Copy Markdown
Contributor Author

/cherry-pick release-1.0

@github-actions github-actions Bot added this to the Release 1.0 milestone Aug 26, 2025
apecloud-bot pushed a commit that referenced this pull request Aug 26, 2025
@apecloud-bot
Copy link
Copy Markdown
Collaborator

🤖 says: cherry pick action finished successfully 🎉!
See: https://github.com/apecloud/kbcli/actions/runs/17237142957

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/S Denotes a PR that changes 10-29 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] kbcli stucks in WAITING FOR ADDONS even though addon list is empty

5 participants