large file support

[adrelanos]

Created a 2G file for test purposes.

fallocate -l 2G test.img

Tried to sign it.

signify-openbsd -S -s ./keyname.sec -m ./test.img -x ./test.img.sig

result:

signify-openbsd: msg too large in ./test.img

Could you please add support for signing arbitrarily large files?

[aperezdc]

I think this is a matter of adding -D_LARGEFILE_SOURCE to the preprocessor flags used during compilation, I'll take a look.

[aperezdc]

Ah, not really, this is an upstream bug, the maximum size is hardcoded as 1 GiB, see the definition of maxmsgsize inside signify.c:

	const unsigned long long maxmsgsize = 1UL << 30;

	fd = xopen(filename, O_RDONLY | O_NOFOLLOW, 0);
	if (fstat(fd, &sb) == 0 && S_ISREG(sb.st_mode)) {
		if (sb.st_size > maxmsgsize)
			errx(1, "msg too large in %s", filename);
		space = sb.st_size + 1;
	} else {
		space = 64 * 1024 - 1;
	}

[adrelanos]

Also reported this upstream by e-mail. Here is my e-mails and the replies:
https://forums.whonix.org/t/signify-openbsd/7842/8