Allow mark_unknown to be actually used in translate#111
Open
ygorg wants to merge 2 commits intoapertium:masterfrom
Open
Allow mark_unknown to be actually used in translate#111ygorg wants to merge 2 commits intoapertium:masterfrom
mark_unknown to be actually used in translate#111ygorg wants to merge 2 commits intoapertium:masterfrom
Conversation
added 2 commits
May 25, 2023 10:48
… pass options to `parse_mode_file`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #82
The option for
mark_unknowntranslation was present but not used. This code fixes that.It also clarifies the role of
$1and$2(variable names come from apertium CLI) inparse_mode_file.This function was untested for the wrapper because I couldn't make it work. For information: in #82 dimitarsh1 dealt with that by prevented using the wrapper when
mark_unknownwas used.