Skip to content

update deformatter (apertium-destxt) escape chars#93

Open
singh-lokendra wants to merge 4 commits intomasterfrom
deformat
Open

update deformatter (apertium-destxt) escape chars#93
singh-lokendra wants to merge 4 commits intomasterfrom
deformat

Conversation

@singh-lokendra
Copy link
Copy Markdown
Collaborator

sushain97
sushain97 previously approved these changes Mar 9, 2021
sushain97
sushain97 previously approved these changes Mar 9, 2021
@sushain97
Copy link
Copy Markdown
Member

(i'm fine with us switching to GH actions but it should really be a separate PR, imo)

@singh-lokendra
Copy link
Copy Markdown
Collaborator Author

I noticed travis builds weren't working so I added the workflow file. I'll make a separate PR for GH acions

@eagad
Copy link
Copy Markdown

eagad commented Mar 10, 2021

@Vaydheesh can you also include ['*', '#', '+', '~'] in escape_chars list, please?

@singh-lokendra
Copy link
Copy Markdown
Collaborator Author

@eagad The escape_chars is used to wrap apertium-destxt which is generated from txt-format.xml.
Since I am not from linguistics background, I don't know whether this change has potential to break things or not.
Maybe other developers can clarify on implications of this change

@singh-lokendra
Copy link
Copy Markdown
Collaborator Author

can you also include ['*', '#', '+', '~'] in escape_chars list, please?

@sushain97 any thoughts on this?

@TinoDidriksen
Copy link
Copy Markdown
Member

*#+~ are not escaped in the input - see https://github.com/apertium/lttoolbox/blob/master/lttoolbox/fst_processor.cc#L39

They are escaped when expanding: https://github.com/apertium/lttoolbox/blob/master/lttoolbox/expander.cc#L116

But de/re-formatters must not touch *#+~.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

terminate called after throwing an instance of 'Exception' what(): Error: Malformed input stream.

4 participants