Conversation
The toro4 setup with a strong discontinuity in the Riemann problem to be solved is not stable with a positivity preserving stabilization on its own. Such a filter is now added and the initial condition is tamed to avoid a narrow peak in the density.
haraldkl
added a commit
to apes-suite/ateles
that referenced
this pull request
Nov 13, 2025
See [PR in ateles-source](apes-suite/ateles-source#17).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The timestep is restricted by the maximal polynomial degree,
in the Q-polynomial that is actually nDims times max polydegree,
while the P-polynomials only have maxpolydegree terms.
The CFL computation should take the actual maximal polynomial
degree into account.