Skip to content

Conversation

@astrauc
Copy link
Contributor

@astrauc astrauc commented Aug 20, 2025

Callable rust API. Includes small changes to the CMakeLists.txt files in root, src folder, api/cpp folder, and keyvalue_parser folder.

Changes to cmake mainly add another option for building, such as build for static linking and building only the libraries. Changes to keyvalue_parser modify where it writes files to (changed to modify to the build tree instead of the source tree)

@mbarger99
Copy link
Contributor

Thanks @astrauc, looks good so far. A couple quick requests if you have time:

@@ -0,0 +1,25 @@
# Rust for Gravity
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed this file at first glance - this covers the setup notes I asked for.

@astrauc
Copy link
Contributor Author

astrauc commented Aug 20, 2025

I have the text for the examples already ready as well, just have to move them over!

I can also move the notes for the setup into the wiki for simplicity

@mbarger99
Copy link
Contributor

It would be good to mention someplace that we have a dependency on at least cargo version 1.85 (edition 2024) - or am I missing something? apt install on Ubuntu 24.04 installs 1.75.0, so would be good to give a heads up. And some environments make installing with https://sh.rustup.rs challenging....

Copy link
Contributor

@mbarger99 mbarger99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After deleting my Cargo.toml file, I was able to get the latest and now the tests and examples work for me even if spdlog is installed locally. Thanks @astrauc!

@mbarger99
Copy link
Contributor

The windows build for this fork is failing because https://cytranet.dl.sourceforge.net/ (where some windows dependencies live) seems to be offline. I don't think it has anything to do with the changes here. Will kick off the build again later when that site is hopefully back online.

@mbarger99 mbarger99 merged commit 4ae5315 into aphysci:master Jan 7, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants