Two bug fixes related to API Platform Admin #132
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
slim
commented
Nov 8, 2023
slim
commented
| Q | A |
|---|---|
| Branch? | main |
| Tickets | |
| License | MIT |
| Doc PR |
- was not handling Content-Type: application/problem+json which is necessary for API-Platform
- getDocumentationFromHeaders() was not extracting URL from Link, when multiple alternative urls were provided
This content type is defined in RFC7807 and is used for errors in Symfony and API-Platform
It was not working when there were multiple urls in the Link: header. There was a defect in the regex
dunglas
approved these changes
Nov 8, 2023
Member
dunglas
left a comment
dunglas
left a comment
There was a problem hiding this comment.
Awesome, thanks! Could you please add tests too? 😁
alanpoulain
approved these changes
Nov 10, 2023
Member
|
Nicely done @slim. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.