feat(httpcache): add more cache directives to AddHeadersProcessor #7008
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanpoulain
force-pushed
the
feat-cache-header-more-directives
branch
from
54c8d75 to
66ffb40
Compare
soyuka
approved these changes
Mar 12, 2025
| 'etag' => $this->etag && !$response->getEtag() ? hash('xxh3', (string) $content) : null, | ||
| 'max_age' => null !== ($maxAge = $resourceCacheHeaders['max_age'] ?? $this->maxAge) && !$response->headers->hasCacheControlDirective('max-age') ? $maxAge : null, | ||
| // Cache-Control "s-maxage" is only relevant is resource is not marked as "private" | ||
| 's_maxage' => false !== $public && null !== ($sharedMaxAge = $resourceCacheHeaders['shared_max_age'] ?? $this->sharedMaxAge) && !$response->headers->hasCacheControlDirective('s-maxage') ? $sharedMaxAge : null, |
Member
There was a problem hiding this comment.
should we add the public check logic? even though I agree I'm not sure we should handle this specific use case
Member
Author
There was a problem hiding this comment.
I don't know but I didn't introduce this check, it was there in the previous code. It will be a BC to remove it.
alexndlm
pushed a commit
to alexndlm/core
that referenced
this pull request
May 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some cache directives were missing from the
AddHeadersProcessor, likeno-store, this PR adds them.