feat(mongodb): Make ParameterExtension context more generic
#7389
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
We can test this inside src/Doctrine/Odm/Tests/Extension/ there are instructions on how to run a test for a specific component inside CONTRIBUTING.md |
GromNaN
force-pushed
the
mongodb-parameters-context
branch
from
1a624f4 to
59c6ace
Compare
GromNaN
force-pushed
the
mongodb-parameters-context
branch
from
59c6ace to
22d1bc3
Compare
GromNaN
force-pushed
the
mongodb-parameters-context
branch
from
22d1bc3 to
a13be92
Compare
GromNaN
commented
Sep 17, 2025
Comment on lines
92
to
97
| $context['filters'] = $values; | ||
| $context['parameter'] = $parameter; | ||
|
|
||
| $filter->apply($aggregationBuilder, $resourceClass, $operation, $context); | ||
|
|
||
| unset($context['filters'], $context['parameter']); |
Contributor
Author
There was a problem hiding this comment.
I changed the implementation to be more straightforward: setting and unsetting fields from the $context array.
soyuka
force-pushed
the
mongodb-parameters-context
branch
from
5ef27de to
83f8f8c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The filter context is passed by reference to each filter instance. In order to let the filters update any key in the context to be accessible in other filter calls, I propose a more generic copy of values.
Only the
filtersandparameterkeys are specific to the current filter call.I don't know how and where to test it.