Skip to content

Conversation

@vincentchalamon
Copy link
Contributor

@vincentchalamon vincentchalamon commented Jun 28, 2024

@vincentchalamon vincentchalamon added the dependencies Pull requests that update a dependency file label Jun 28, 2024
@fzaninotto
Copy link
Contributor

This won't work as you're bundling 2 incompatible versions of react-admin (v5 as direct dependency, and v4 as dependency of @api-platform/admin).

You'll need to wait for api-platform/admin#572 to be merged and released.

@vincentchalamon vincentchalamon force-pushed the feat/react-admin-v5 branch 2 times, most recently from 1bcc4ba to bee201b Compare July 15, 2024 13:58
@fzaninotto
Copy link
Contributor

What's left to get it finished? Do you need a hand?

@vincentchalamon
Copy link
Contributor Author

I need to investigate why the @read E2E tests are failing. Feel free to check if you have some time :-)

@vincentchalamon vincentchalamon marked this pull request as ready for review August 9, 2024 09:18
@vincentchalamon vincentchalamon merged commit 3af7858 into main Aug 9, 2024
@vincentchalamon vincentchalamon deleted the feat/react-admin-v5 branch August 9, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upgrade to react-admin v5

2 participants