fix: nullabe arrays of decoded ids were retrieved as [null]#211
Merged
Mohammad-Alavi merged 2 commits intoapiato:8.xfrom Sep 29, 2024
Merged
Conversation
yalsicor
approved these changes
Sep 25, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 8.x #211 +/- ##
==========================================
- Coverage 7.78% 3.42% -4.36%
- Complexity 658 659 +1
==========================================
Files 99 99
Lines 2711 2713 +2
==========================================
- Hits 211 93 -118
- Misses 2500 2620 +120 ☔ View full report in Codecov by Sentry. |
Member
|
Perfect! |
Mohammad-Alavi
added a commit
that referenced
this pull request
Oct 1, 2024
* fix: nullabe arrays of decoded ids were retrieved as [null] * test: add covers attribute --------- Co-authored-by: Mohammad Alavi <Mohammad.alavi1990@gmail.com>
yalsicor
pushed a commit
to openforests-git/apiato-core
that referenced
this pull request
Oct 1, 2024
* fix: nullabe arrays of decoded ids were retrieved as [null] * test: add covers attribute --------- Co-authored-by: Mohammad Alavi <Mohammad.alavi1990@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
There is an Apiato bug that prevented arrays of decoded ids to be nullable, due to the
HashIdTraitprocessField()method working over null data. This PR fixes that.