Skip to content

ci: catch formatting issues at PR time#769

Merged
B4nan merged 2 commits into
masterfrom
claude/trusting-johnson-ef0e03
May 14, 2026
Merged

ci: catch formatting issues at PR time#769
B4nan merged 2 commits into
masterfrom
claude/trusting-johnson-ef0e03

Conversation

@B4nan
Copy link
Copy Markdown
Member

@B4nan B4nan commented May 14, 2026

Summary

Adds prettier --check to the lint/test workflow. Today, formatting drift in shared files (notably the agent-bases/*.AGENTS.md source-of-truth that gets fanned out into every template's AGENTS.md) only surfaces after merge, when the per-template e2e checks fire — see the post-merge comment on #766.

This PR adds the check only; the resulting CI failure is intentional and demonstrates the gap. A follow-up commit on the same branch will reformat the offending files so the check goes green.

🤖 Generated with Claude Code

Catches formatting issues at PR time rather than only after they propagate
to template AGENTS.md files and break downstream e2e tests.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@github-actions github-actions Bot added this to the 140th sprint - Tooling team milestone May 14, 2026
@github-actions github-actions Bot added the t-tooling Issues with this label are in the ownership of the tooling team. label May 14, 2026
Reformats the shared agent-base files (which fan out to every template's
AGENTS.md via copy-agents-md-to-templates) and a small drift in renovate.json
so the new format check from the previous commit goes green.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@B4nan B4nan added the adhoc Ad-hoc unplanned task added during the sprint. label May 14, 2026
@B4nan B4nan enabled auto-merge (squash) May 14, 2026 08:48
@B4nan B4nan merged commit c6ac85d into master May 14, 2026
42 of 43 checks passed
@B4nan B4nan deleted the claude/trusting-johnson-ef0e03 branch May 14, 2026 09:36
B4nan added a commit that referenced this pull request May 18, 2026
Master picked up a prettier --check CI gate (#769) and bumped
playwright/puppeteer pins; this commit fixes formatting in files
the migration introduced and resyncs pnpm-lock.yaml.

- Add pnpm-lock.yaml to .prettierignore (autogenerated).
- Reformat pnpm-workspace.yaml and test/templates.test.js.
- Resync pnpm-lock.yaml with playwright@1.60.0 / puppeteer@24.43.1
  pins that master moved to.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants