feat: call with inputs#577
Merged
Merged
Conversation
github-actions
Bot
added
t-tooling
Member
|
Looking good to me! I even played with it a little and nothing broke 🎉 (and what's more important I guess, I was able to understand and recover my bash typos and mistakes without causing too much havoc). |
janbuchar
reviewed
Jun 17, 2024
Contributor
janbuchar
left a comment
janbuchar
left a comment
There was a problem hiding this comment.
Looks OK, just one possible refactor and one thing I don't understand.
janbuchar
reviewed
Jun 20, 2024
Contributor
|
Seems all ok to me, but also a nit: I don't see an e2e test for the stdin input. I would love to have a test for it as an executable acceptance criterion. We've spent a lot of time discussing it and we should preserve that product decision for future generations. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #497