Skip to content

Conversation

@sufyankhanrao
Copy link
Collaborator

@sufyankhanrao sufyankhanrao commented Jun 11, 2025

What

This PR fixes the api logging configuration by writing a __deep_copy__ method in the classes to handle the logger cloning as logger can't be pickled. Also, this commit narrows down the pagination type to be applied for subsequent calls after the 1 call.

Why

  1. To fix the behavior of logging with pagination
  2. To following the feature consistent across all languages by locking a pagination type

Closes #98

Type of change

Select multiple if applicable.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause a breaking change)
  • Tests (adds or updates tests)
  • Documentation (adds or updates documentation)
  • Refactor (style improvements, performance improvements, code refactoring)
  • Revert (reverts a commit)
  • CI/Build (adds or updates a script, change in external dependencies)

Dependency Change

If a new dependency is being added, please ensure that it adheres to the following guideline https://github.com/apimatic/apimatic-codegen/wiki/Policy-of-adding-new-dependencies-in-the-core-libraries

Breaking change

If the PR is introducing a breaking change, please ensure that it adheres to the following guideline https://github.com/apimatic/apimatic-codegen/wiki/Guidelines-for-maintaining-core-libraries

Testing

List the steps that were taken to test the changes

Checklist

  • My code follows the coding conventions
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added new unit tests

This commit fixes the api logging configuration by writing a `__deep_clone__` method in the classes to handle the logger cloning as logger can't be pickled. Also, this commit narrows down the pagination type to be applied for subsequent calls after the 1 call.

Closes #98
@sufyankhanrao sufyankhanrao requested a review from asadali214 June 11, 2025 08:19
@sufyankhanrao sufyankhanrao self-assigned this Jun 11, 2025
@sonarqubecloud
Copy link

@sufyankhanrao sufyankhanrao merged commit 1f88e77 into main Jun 11, 2025
9 checks passed
@sufyankhanrao sufyankhanrao deleted the 98-fix-logging-with-pagination branch June 11, 2025 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Pagination does not work with logging

3 participants