Skip to content

Conversation

@MuHamza30
Copy link
Contributor

@MuHamza30 MuHamza30 commented Jun 13, 2025

What

Added a check to ensure curl_exec response is a string before processing to prevent potential fatal errors.

Why

curl_exec can return non-string values on failure, which could cause fatal errors if not handled.

Closes #59

Type of change

Select multiple if applicable.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause a breaking change)
  • Tests (adds or updates tests)
  • Documentation (adds or updates documentation)
  • Refactor (style improvements, performance improvements, code refactoring)
  • Revert (reverts a commit)
  • CI/Build (adds or updates a script, change in external dependencies)

Dependency Change

If a new dependency is being added, please ensure that it adheres to the following guideline https://github.com/apimatic/apimatic-codegen/wiki/Policy-of-adding-new-dependencies-in-the-core-libraries

Breaking change

If the PR is introducing a breaking change, please ensure that it adheres to the following guideline https://github.com/apimatic/apimatic-codegen/wiki/Guidelines-for-maintaining-core-libraries

Testing

List the steps that were taken to test the changes

Checklist

  • My code follows the coding conventions
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added new unit tests

@MuHamza30 MuHamza30 requested a review from asadali214 June 13, 2025 04:54
@MuHamza30 MuHamza30 self-assigned this Jun 13, 2025
@sonarqubecloud
Copy link

@asadali214 asadali214 merged commit bdfd5f2 into v2-master Jun 17, 2025
3 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Potential fatal error when curl_exec returns non-string value.

4 participants