Skip to content

Conversation

@nobodyiam
Copy link
Member

@nobodyiam nobodyiam commented Jan 1, 2026

What's the purpose of this PR

automatically retry ut 3 times on error

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Read the Contributing Guide before making this pull request.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit tests to verify the code.
  • Run mvn clean test to make sure this pull request doesn't break anything.
  • Update the CHANGES log.

Summary by CodeRabbit

  • Chores
    • Enhanced build pipeline resilience by adding retry logic to the JDK 8 build step, improving reliability when transient failures occur during the build process.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 1, 2026

📝 Walkthrough

Walkthrough

The JDK 8 build step in the GitHub Actions workflow is wrapped with a retry action that automatically re-attempts the build on failure using configurable timeout, maximum attempts, and wait duration parameters.

Changes

Cohort / File(s) Summary
CI/CD Workflow Retry Logic
\.github/workflows/build\.yml
Wrapped JDK 8 Maven build step with nick-fields/retry@v3 action to handle transient failures with timeout and retry configuration

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 A retry here, a retry there,
The build now bounces through the air!
When Maven stumbles, springs back up,
With patience measured, try again—no sup.
Resilience wrapped in workflow care! 🔄

Pre-merge checks

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: adding retry logic to the GitHub Actions unit test workflow, which aligns with the PR's objective to automatically retry unit tests on error.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@nobodyiam nobodyiam changed the title retry ut on error Add retry logic to github unit test action Jan 1, 2026
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
.github/workflows/build.yml (1)

46-53: Consider pinning the retry action to a commit SHA.

For better supply-chain security, pin the action to a specific commit SHA instead of a tag. GitHub recommends this approach to ensure immutability and prevent tag tampering (e.g., nick-fields/retry@v3nick-fields/retry@<commit-sha>). To find the commit SHA for v3, use: git ls-remote https://github.com/nick-fields/retry refs/tags/v3.

The timeout_minutes: 3 setting is worth validating against recent workflow run durations to ensure it's sufficient for the full Maven build with tests and coverage reporting on the Ubuntu runner.

Note: v3 is the latest major version (v3.0.2 as of Feb 2025) and has no published critical security advisories. However, third-party security scanners flag lower maintenance and security hygiene compared to some alternatives; if enhanced supply-chain assurance is required, audit dependencies or consider alternatives like step-security/retry.

📜 Review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0a8c618 and 9aa8a2e.

📒 Files selected for processing (1)
  • .github/workflows/build.yml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: build (8)

@nobodyiam nobodyiam merged commit 893685f into apolloconfig:main Jan 1, 2026
8 checks passed
@nobodyiam nobodyiam deleted the retry_ut branch January 1, 2026 05:35
@github-actions github-actions bot locked and limited conversation to collaborators Jan 1, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant