merge multiplication counter test#7
Merged
bpurinton merged 2 commits intoappdev-projects:mainfrom Feb 10, 2023
Merged
Conversation
jelaniwoods
approved these changes
Feb 6, 2023
Contributor
jelaniwoods
left a comment
jelaniwoods
left a comment
There was a problem hiding this comment.
@bpurinton Thanks for the PR!
but I'm not sure we need to worry about every single edge case.
I agree, we don't need to address every edge case in these tests.
I had one minor suggestion about the error message, but you can take it or leave it.
LGTM, you can merge when ready.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is my first attempt at a merge into the course material, and my first time requesting code review. So bear with me.
Problem
I wanted to patch the
string_multiplication.rbtest to prevent it from passing with the codeSolution
I made a counter, looped through the file, and searched for the presence of
*, with the condition that it doesn't occur on a commented line. So as long as there is one*in their code somewhere, it passes.Why I request review
I'm not sure if my solution is good and logical, or if it could be improved. Also, there are still other ways I could imagine cheating the test like:
but I'm not sure we need to worry about every single edge case.