Merged
Conversation
tlconnor
force-pushed
the
fixSelectFocusIssue
branch
2 times, most recently
from
ef2dfdb to
642e600
Compare
tlconnor
force-pushed
the
fixSelectFocusIssue
branch
from
642e600 to
c761327
Compare
Author
|
JedWatson/react-select#1512 has been merged to react-select, but we have no idea when the next release might be so I'd suggest we still go ahead with this fix. |
Contributor
|
Sounds good, thanks for the fix |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a bug in react-select where the currently selected item will lose focus if the
optionslist changes, even if the selected option still exists.There is a PR to fix this on
react-selectJedWatson/react-select#1512 but the author does not seem to be very resposive to PRs.In the meantime this PR takes the fix and applies it directly within react-gears. This is intended as a temporary fix until the real one gets merged.
Before:
After:
