-
-
Notifications
You must be signed in to change notification settings - Fork 6.3k
fix(appium): appium symlink behavior across drivers/plugins installations #21837
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| "rimraf": "6.1.2", | ||
| "serve-static": "2.2.1", | ||
| "sinon": "21.0.1", | ||
| "sinon-chai": "4.0.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need this import?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this is used to write some syntax for assertions. I assume we have this before...? since the type exists in the package.json already.
Proposed changes
This is related to #21664. I noticed this issue in https://github.com/appium/ruby_lib_core/actions/runs/20587570810.
The issue occurs in drivers when we install plugins, or plugins when we install drivers.
e.g.
Expected behavior is even after the plugin installation, the symlink to xcuitest should exist.
Types of changes
What types of changes does your code introduce to Appium?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...