Skip to content

Conversation

@KazuCocoa
Copy link
Member

@KazuCocoa KazuCocoa commented Dec 30, 2025

Proposed changes

This is related to #21664. I noticed this issue in https://github.com/appium/ruby_lib_core/actions/runs/20587570810.

The issue occurs in drivers when we install plugins, or plugins when we install drivers.

e.g.

appium driver install xcuitest
appium plugin install images  # then, the appium symlink in the node_modules in xcuitest is missing

Expected behavior is even after the plugin installation, the symlink to xcuitest should exist.

Types of changes

What types of changes does your code introduce to Appium?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the Contributing Guide
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@github-actions github-actions bot added appium core Bug a problem that needs fixing labels Dec 30, 2025
@KazuCocoa KazuCocoa changed the title fix(appium): appium symlink behavior with plugins fix(appium): appium symlink behavior across drivers/plugins installations Dec 30, 2025
@github-actions github-actions bot added chore refactoring, overhead, tests, etc. Dependencies issues with dependencies labels Dec 30, 2025
"rimraf": "6.1.2",
"serve-static": "2.2.1",
"sinon": "21.0.1",
"sinon-chai": "4.0.1",
Copy link
Collaborator

@mykola-mokhnach mykola-mokhnach Dec 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need this import?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is used to write some syntax for assertions. I assume we have this before...? since the type exists in the package.json already.

@KazuCocoa KazuCocoa merged commit 529aeb4 into master Dec 30, 2025
48 checks passed
@KazuCocoa KazuCocoa deleted the fix-appium-symlink branch December 30, 2025 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

appium core Bug a problem that needs fixing chore refactoring, overhead, tests, etc. Dependencies issues with dependencies

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants