change capabilities to use w3c compliant prefixes#1324
Closed
titusfortner wants to merge 1 commit intoappium:masterfrom
Closed
change capabilities to use w3c compliant prefixes#1324titusfortner wants to merge 1 commit intoappium:masterfrom
titusfortner wants to merge 1 commit intoappium:masterfrom
Conversation
Contributor
Author
|
(this is draft because I'm not sure how you want the tests handled, and if this should wait for #1319) |
| * manifest (action: android.intent.action.MAIN , category: android.intent.category.LAUNCHER) | ||
| */ | ||
| String APP_ACTIVITY = "appActivity"; | ||
| String APP_ACTIVITY = "appium:appActivity"; |
Contributor
There was a problem hiding this comment.
it makes sense to have a separate constant defined for appium:
Contributor
|
I think we cannot merge this change yet, because it will break mjsonwp tests. Actually, it's the same reason we don't incorporate the alpha version of selenium 4 lib - users want to have stable releases rather than alpha snapshots. |
Contributor
Author
|
Nevermind, you are automatically doing what is needed here: and I just missed it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change list
appium:Types of changes
What types of changes are you proposing/introducing to Java client?
Details
This makes java-client compliant with required w3c syntax, which will likely be necessary when users update to Selenium 4.
The tests like
startingAndroidAppWithCapabilitiesOnlyTestfail with this PR, but I would consider these more unit tests than user facing changes because no one should be checking the input to Capabilities with the output from the server.That said, if we have #1319 we could override
getCapabilityto addappium:if we need the inputs to match the outputs.I also do not know if or how settings might need to be adjusted to ensure compatible versions of things are used.