feat: Add a possibility to connect to a running session#1813
Merged
mykola-mokhnach merged 4 commits intoappium:masterfrom Dec 5, 2022
Merged
feat: Add a possibility to connect to a running session#1813mykola-mokhnach merged 4 commits intoappium:masterfrom
mykola-mokhnach merged 4 commits intoappium:masterfrom
Conversation
KazuCocoa
approved these changes
Dec 4, 2022
Member
There was a problem hiding this comment.
seems reasonable to me to set platfornName and automationName as no definition in w3c to get current session info.
I remember that I also got a couple of questions about this attach to an existing session long before. the main usage was for debugging to attach to a running automation session like current appium inspector's attach to an existing session in another language
SrinivasanTarget
approved these changes
Dec 5, 2022
valfirst
approved these changes
Dec 5, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change list
I am still not quite sure what the purpose of such feature, but people have been asking for it.
The main issue is that Selenium API does not have a concept of session state, so we cannot reliably share it across multiple client instances. But we still can send commands, which is probably enough for debugging and other weird purposes.
The concept is simple, - all drivers got an additional public constructor, which accepts the remote session url (e.g. server url + "/session/id" prefix) and platform/automation name where necessary. The created "generic" driver only knows about the actual session id. Otherwise it is always assumed it is a valid Appium session using the W3C protocol.
Types of changes