refactor: Replace non-W3C API calls with corresponding extension calls in app management#1883
Merged
mykola-mokhnach merged 3 commits intoappium:masterfrom Apr 14, 2023
Merged
Conversation
mykola-mokhnach
requested review from
SrinivasanTarget,
saikrishna321 and
valfirst
as code owners
valfirst
approved these changes
Apr 14, 2023
KazuCocoa
approved these changes
Apr 14, 2023
KazuCocoa
reviewed
Apr 14, 2023
| args.put("bundleId", bundleId); | ||
| args.put("appId", bundleId); | ||
| Optional.ofNullable(options).map(BaseOptions::build).ifPresent(args::putAll); | ||
| return CommandExecutionHelper.executeScript(this, "mobile: terminateApp", args); |
Member
There was a problem hiding this comment.
btw, does this include for mac2 driver as well? Then, mac2 driver needs macos instead of mobile
https://github.com/appium/appium-mac2-driver#macos-terminateapp
(queryAppState etc as well)
Contributor
Author
There was a problem hiding this comment.
no, only AndroidDriver and IOSDriver implement this interface
This was referenced Apr 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change list
Eventually we should avoid creating wrappers for non-W3C-compatible endpoints as these endpoints are mostly legacy from mobile-specific commands. We should only provide
mobile:extension for these.I don't want to remove existing wrappers though as this could create extra headaches for clients. These should work same way as before, but call corresponding extensions under the hood.
I would say it makes sense to introduce similar changes to other clients as well (e.g. Python/Dotnet/Ruby)
cc @KazuCocoa @jlipps @Dor-bl