fix: Correct spelling and semantic mistakes in method naming#1970
fix: Correct spelling and semantic mistakes in method naming#1970mykola-mokhnach merged 1 commit intoappium:masterfrom
Conversation
|
|
Could you please sign CLA? |
|
I should have now signed the CLA |
|
In order to not make this change breaking it would make sence to mark method names containing typos as |
|
The changes should reflect your suggestion now @mykola-mokhnach: Deprecated rather than remove methods containing typos. |
...in/java/io/appium/java_client/android/options/context/SupportsShowChromedriverLogOption.java
Outdated
Show resolved
Hide resolved
...in/java/io/appium/java_client/android/options/context/SupportsShowChromedriverLogOption.java
Outdated
Show resolved
Hide resolved
src/main/java/io/appium/java_client/ios/options/simulator/SupportsCustomSslCertOption.java
Show resolved
Hide resolved
...in/java/io/appium/java_client/ios/options/simulator/SupportsSimulatorTracePointerOption.java
Outdated
Show resolved
Hide resolved
|
@valfirst happy to work around the Checkstyle issue, however the actual checkstyle issue is apparent because it thinks the deprecated method In this case there is only the two methods in the class and moving it up shouldn't affect anything else, but workaround the checkstyle issue. I will push this change now. |
…1967) - affects SupportsCustomSslCertOption, SupportsShowChromedriverLogOption and SupportsSimulatorTracePointerOption
Change list
SupportsCustomSslCertOptionmethodsetCustomSSLCert()is nowgetCustomSSLCert()affectsXCUITestOptionsSupportsSimulatorTracePointerOptionmethoddoesSimulatorTracePointerd()is nowdoesSimulatorTracePointer()affectsXCUITestOptionSupportsShowChromedriverLogOptionmethodssetDhowChromedriverLog(boolean)anddoesDhowChromedriverLog()are nowsetShowChromedriverLog(boolean)anddoesShowChromedriverLog()respectively affectsExpressoOptionsandUIAutomator2OptionsTypes of changes
What types of changes are you proposing/introducing to Java client?
Put an
xin the boxes that applyDetails
No functional changes