Skip to content

ci: Run tests against latest Selenium release #1978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
valfirst merged 1 commit into from
Aug 18, 2023
Merged

ci: Run tests against latest Selenium release #1978

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,12 +61,11 @@ dependencies {
testImplementation (group: 'io.github.bonigarcia', name: 'webdrivermanager', version: '5.3.3') {
exclude group: 'org.seleniumhq.selenium'
}
testImplementation ('org.seleniumhq.selenium:selenium-chrome-driver') {
version {
strictly "[${seleniumVersion}, 5.0)"
prefer "${seleniumVersion}"
}
}
testImplementation platform(group: 'org.seleniumhq.selenium', name: 'selenium-bom', version: '4.11.0')
Copy link
Copy Markdown
Contributor

@mykola-mokhnach mykola-mokhnach Aug 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are you sure you want to merge this? how about seleniumVersion then?

Copy link
Copy Markdown
Collaborator Author

@valfirst valfirst Aug 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seleniumVersion will be used in published POM and will declare minimal support version of Selenium
as for the test stage Gradle will resolve conflicts and will pick up the latest version (== declared in test scope), so all tests will be run against the latest version

Copy link
Copy Markdown
Contributor

@mykola-mokhnach mykola-mokhnach Aug 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if this is only for tests then should be ok

testImplementation 'org.seleniumhq.selenium:selenium-api'
testImplementation 'org.seleniumhq.selenium:selenium-remote-driver'
testImplementation 'org.seleniumhq.selenium:selenium-support'
testImplementation 'org.seleniumhq.selenium:selenium-chrome-driver'
testRuntimeOnly "org.slf4j:slf4j-simple:${slf4jVersion}"
}

Expand Down