chore: patch AutomationName with Chromium#1993
Merged
mykola-mokhnach merged 2 commits intoappium:masterfrom Sep 1, 2023
Merged
chore: patch AutomationName with Chromium#1993mykola-mokhnach merged 2 commits intoappium:masterfrom
mykola-mokhnach merged 2 commits intoappium:masterfrom
Conversation
AlessandroMiccoli
requested review from
SrinivasanTarget,
mykola-mokhnach,
saikrishna321 and
valfirst
as code owners
AlessandroMiccoli
changed the title
mykola-mokhnach
approved these changes
Aug 31, 2023
Contributor
|
@AlessandroMiccoli could you please sign the CLA? |
Contributor
Author
|
I already signed the CLA. I received an email. Do I need to do something else?
|
AlessandroMiccoli
changed the title
Contributor
Author
|
/easycla |
mykola-mokhnach
changed the title
Contributor
|
@AlessandroMiccoli Make sure that the email address in your local github config matches with the one used to sign CLA |
AlessandroMiccoli
force-pushed
the
feature/ISSUE_1991
branch
2 times, most recently
from
cb24b6a to
a25cbb5
Compare
Contributor
Author
|
I fixed the issue with the CLA. |
SrinivasanTarget
approved these changes
Sep 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change list
Patch AutomationName with Chromium variable.
Types of changes
What types of changes are you proposing/introducing to Java client?
Put an
xin the boxes that applyDetails
For running the Chromium driver, we need to set the automation name to Chromium. So, I added this variable to the interface.